Do not overload index with WithdrawalIndex and ValidatorIndex#2953
Merged
djrtwo merged 1 commit intoethereum:devfrom Aug 1, 2022
Merged
Do not overload index with WithdrawalIndex and ValidatorIndex#2953djrtwo merged 1 commit intoethereum:devfrom
djrtwo merged 1 commit intoethereum:devfrom
Conversation
Member
|
fwiw the types do not change and I'd say this implies the meaning does not change but I'd support this PR if it clarifies things |
Contributor
Author
I think the confusing thing is statements like index=state.next_withdrawal_index,
address=ExecutionAddress(state.validators[index].withdrawal_credentials[12:]),Where in one line |
hwwhww
approved these changes
Jul 29, 2022
Contributor
hwwhww
left a comment
hwwhww
left a comment
There was a problem hiding this comment.
Agreed that index=state.next_withdrawal_index, address=ExecutionAddress(state.validators[index].withdrawal_credentials[12:]) is confusing. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the function
withdraw_balancethe variableindextakes different meanings and types. This confused at least one member of our team.